ficd/zmk
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Use hold-trigger-on-release PR

Browse source
This commit is contained in:
urob 2022-08-05 23:18:03 -04:00
parent d3b02851bd
commit 54bb4f82fa
2 changed files with 12 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

2
config/base.keymap
View file

@ -75,6 +75,7 @@ ZMK_BEHAVIOR(hml, hold_tap, // left-hand HRMs
global-quick-tap-ms = <150>; global-quick-tap-ms = <150>;
bindings = <&kp>, <&kp>; bindings = <&kp>, <&kp>;
hold-trigger-key-positions = <KEYS_R THUMBS>; hold-trigger-key-positions = <KEYS_R THUMBS>;
hold-trigger-on-release; // requires PR #1423
) )
ZMK_BEHAVIOR(hmr, hold_tap, // right-hand HRMs ZMK_BEHAVIOR(hmr, hold_tap, // right-hand HRMs
@ -84,6 +85,7 @@ ZMK_BEHAVIOR(hmr, hold_tap, // right-hand HRMs
global-quick-tap-ms = <150>; global-quick-tap-ms = <150>;
bindings = <&kp>, <&kp>; bindings = <&kp>, <&kp>;
hold-trigger-key-positions = <KEYS_L THUMBS>; hold-trigger-key-positions = <KEYS_L THUMBS>;
hold-trigger-on-release; // requires PR #1423
) )
/* custom keys and macros */ /* custom keys and macros */

18
readme.md
View file

@ -53,13 +53,12 @@ This is almost perfect, but there's still a few rough edges:
hold-tap" feature to force HRMs to always resolve as "tap" when the *next* key is on hold-tap" feature to force HRMs to always resolve as "tap" when the *next* key is on
the same side of the keyboard. Problem solved. the same side of the keyboard. Problem solved.
* ... or at least almost. The official ZMK version for positional-hold-taps performs the * ... or at least almost. The official ZMK version for positional-hold-taps performs the
check whether the next key is on the same side of the keyboard upon *key check whether the next key is on the same side of the keyboard upon *key press*. This
press*. This is not ideal, because it prevents combining two modifiers on the same is not ideal, because it prevents combining two modifiers on the same hand. To fix
hand. To fix this, I use a small patch that delays the positional-hold-tap decision this, I use a small patch that delays the positional-hold-tap decision until *key
until *key release*. This way, multiple mods can be combined, while I still get the release* ([PR #1423](https://github.com/zmkfirmware/zmk/pull/1423)). This way, multiple
benefit from positional-hold-taps when tapping keys. There is no PR yet (I am still in mods can be combined, while I still get the benefit from positional-hold-taps when
an early testing stage), but if you want to try, this is the [testing tapping keys.
branch](https://github.com/urob/zmk/tree/positional-hold-tap-on-release).
* So far, nothing of the configuration depends on the duration of `tapping-term-ms`. In * So far, nothing of the configuration depends on the duration of `tapping-term-ms`. In
practice, there are two reasons why I don't set it to eternity: practice, there are two reasons why I don't set it to eternity:
1. Sometimes, in rare circumstances, I want to use a mod with a key *on 1. Sometimes, in rare circumstances, I want to use a mod with a key *on
@ -92,6 +91,7 @@ ZMK_BEHAVIOR(hml, hold_tap,
global-quick-tap-ms = <150>; // without PR #1387 use global-quick-tap instead global-quick-tap-ms = <150>; // without PR #1387 use global-quick-tap instead
bindings = <&kp>, <&kp>; bindings = <&kp>, <&kp>;
hold-trigger-key-positions = <KEYS_R THUMBS>; hold-trigger-key-positions = <KEYS_R THUMBS>;
hold-trigger-on-release; // requires PR #1423
) )
/* right-hand HRMs */ /* right-hand HRMs */
@ -102,6 +102,7 @@ ZMK_BEHAVIOR(hmr, hold_tap,
global-quick-tap-ms = <150>; // without PR #1387 use global-quick-tap instead global-quick-tap-ms = <150>; // without PR #1387 use global-quick-tap instead
bindings = <&kp>, <&kp>; bindings = <&kp>, <&kp>;
hold-trigger-key-positions = <KEYS_L THUMBS>; hold-trigger-key-positions = <KEYS_L THUMBS>;
hold-trigger-on-release; // requires PR #1423
) )
``` ```
One last note, the configuration above uses some syntactic sugar introduced in [PR One last note, the configuration above uses some syntactic sugar introduced in [PR
@ -112,8 +113,7 @@ similar effect (`global-quick-tap` will use the regular `quick-tap-ms` timeout i
case). case).
My personal [ZMK fork](https://github.com/urob/zmk) includes both the My personal [ZMK fork](https://github.com/urob/zmk) includes both the
global-quick-tap-ms PR as well as the positonal-hold-tap tweak (along with a few other global-quick-tap-ms PR and the hold-trigger-on-release PR (along with a few other PRs).
PRs).
## A few thoughts on the combo setup ## A few thoughts on the combo setup